feat(ui5-page): implement responsive paddings #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested changes
Jun 8, 2021
ilhan007
reviewed
Jun 11, 2021
| opacity: 1; | ||
| bottom: 0.5rem; | ||
| } | ||
| /*** Responsive paddings ***/ |
There was a problem hiding this comment.
Last thing, should we also handle the case when a ui5-bar is used in the footer, when it is not floating, but regular one - similar to the header styles :host([media-range="S"]) ::slotted([ui5-bar][slot="header"]):
:host([media-range="S"]:not([floating-footer])) ::slotted([ui5-bar][slot="footer"] {There was a problem hiding this comment.
When the bar is not floating, it should always has a width of 100% from the page. (No paddings at all)
|
I am pulling @MapTo0 into the PR to have a final look as we are going to merge this soon if no concerns |
ilhan007
approved these changes
Jun 15, 2021
fifoosid
added a commit
that referenced
this pull request
Jun 21, 2021
kskondov
pushed a commit
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3388