Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-busy-indicator): add new "delay" property #3419

Merged
merged 10 commits into from
Jun 14, 2021
Merged

feat(ui5-busy-indicator): add new "delay" property #3419

merged 10 commits into from
Jun 14, 2021

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Jun 9, 2021 •
edited
Loading

Also added new "busyDelay" property to ui5-list, ui5-table, ui5-li-notification-group, ui5-li-notification.

@TeodorTaushanov TeodorTaushanov requested review from a team, ilhan007, vladitasev and fifoosid June 9, 2021 12:41
fifoosid
fifoosid previously requested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add tests for the new use cases. Some minor comments to be addressed as well.

packages/fiori/src/NotificationListGroupItem.hbs Outdated Show resolved Hide resolved
packages/fiori/src/NotificationListItem.hbs Outdated Show resolved Hide resolved
packages/main/src/List.js Outdated Show resolved Hide resolved
packages/main/test/specs/BusyIndicator.spec.js Show resolved Hide resolved
@TeodorTaushanov TeodorTaushanov requested a review from fifoosid June 10, 2021 13:20
fifoosid
fifoosid previously approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for review from @SAP/ui5-webcomponents-topic-rd and we can merge it

dimovpetar
dimovpetar previously requested changes Jun 11, 2021
View reviewed changes
packages/fiori/src/NotificationListGroupItem.hbs Outdated Show resolved Hide resolved
packages/main/src/BusyIndicator.js Outdated Show resolved Hide resolved
packages/main/src/BusyIndicator.js Show resolved Hide resolved
@TeodorTaushanov TeodorTaushanov requested review from fifoosid, dimovpetar and a team June 11, 2021 09:25
@fifoosid fifoosid merged commit cc8acc7 into master Jun 14, 2021
@fifoosid fifoosid deleted the BusyIndicatorDelay branch June 14, 2021 10:07
@georgimkv georgimkv mentioned this pull request Jun 14, 2021
Closed
@georgimkv georgimkv mentioned this pull request Jun 14, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimovpetar dimovpetar dimovpetar approved these changes

@fifoosid fifoosid fifoosid approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeodorTaushanov @fifoosid @dimovpetar