Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-select): Change focus of options on keypress #3538

Merged
merged 6 commits into from
Aug 2, 2021

Conversation

IlianaB
Copy link
Member

@IlianaB IlianaB commented Jul 26, 2021

Implement changing of focus of options on keypress - typing letters now allows focusing different options of the ui5-select.

Fixes: #3476

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-requested a review July 26, 2021 08:02
@ilhan007 ilhan007 closed this Jul 26, 2021
@ilhan007 ilhan007 reopened this Jul 26, 2021
@ilhan007
Copy link
Member

Eslint errros, you can run yarn lint locally in the root of the project:

/home/travis/build/SAP/ui5-webcomponents/packages/main/src/Select.js
  480:3  error  'sText' is never reassigned. Use 'const' instead          prefer-const
  494:7  error  'oItemToSelect' is never reassigned. Use 'const' instead  prefer-const
  496:1  error  Expected indentation of 2 tabs but found 3                indent
  497:1  error  Expected indentation of 3 tabs but found 4                indent
  499:1  error  Expected indentation of 3 tabs but found 4                indent
  501:1  error  Expected indentation of 3 tabs but found 4                indent
  502:1  error  Expected indentation of 4 tabs but found 5                indent
  503:1  error  Expected indentation of 3 tabs but found 4                indent
  504:1  error  Expected indentation of 2 tabs but found 3                indent
 9 problems (9 errors, 0 warnings)
  8 errors and 0 warnings potentially fixable with the `--fix` option.

In addition, you can rebase with the master, as some randomly failing tests have been fixed. Could avoid some build failures, that have nothing to do with this change.

@IlianaB IlianaB force-pushed the select-typing-search branch from 037b017 to cbcc304 Compare July 26, 2021 11:14
@IlianaB
Copy link
Member Author

IlianaB commented Jul 26, 2021

Eslint errros, you can run yarn lint locally in the root of the project:

/home/travis/build/SAP/ui5-webcomponents/packages/main/src/Select.js
  480:3  error  'sText' is never reassigned. Use 'const' instead          prefer-const
  494:7  error  'oItemToSelect' is never reassigned. Use 'const' instead  prefer-const
  496:1  error  Expected indentation of 2 tabs but found 3                indent
  497:1  error  Expected indentation of 3 tabs but found 4                indent
  499:1  error  Expected indentation of 3 tabs but found 4                indent
  501:1  error  Expected indentation of 3 tabs but found 4                indent
  502:1  error  Expected indentation of 4 tabs but found 5                indent
  503:1  error  Expected indentation of 3 tabs but found 4                indent
  504:1  error  Expected indentation of 2 tabs but found 3                indent
 9 problems (9 errors, 0 warnings)
  8 errors and 0 warnings potentially fixable with the `--fix` option.

In addition, you can rebase with the master, as some randomly failing tests have been fixed. Could avoid some build failures, that have nothing to do with this change.

Done. It seems like have executed the eslint check in the wrong directory.

Copy link
Contributor

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Works fine with different scenarios.

packages/main/src/Select.js Outdated Show resolved Hide resolved
packages/main/src/Select.js Outdated Show resolved Hide resolved
packages/main/src/Select.js Outdated Show resolved Hide resolved
packages/main/src/Select.js Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jul 31, 2021

CLA assistant check
All committers have signed the CLA.

@IlianaB IlianaB requested a review from fifoosid August 2, 2021 07:40
@fifoosid fifoosid merged commit 4657395 into SAP:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change focus of options on keypress
5 participants