-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-select): Change focus of options on keypress #3538
Conversation
Eslint errros, you can run yarn lint locally in the root of the project: /home/travis/build/SAP/ui5-webcomponents/packages/main/src/Select.js
480:3 error 'sText' is never reassigned. Use 'const' instead prefer-const
494:7 error 'oItemToSelect' is never reassigned. Use 'const' instead prefer-const
496:1 error Expected indentation of 2 tabs but found 3 indent
497:1 error Expected indentation of 3 tabs but found 4 indent
499:1 error Expected indentation of 3 tabs but found 4 indent
501:1 error Expected indentation of 3 tabs but found 4 indent
502:1 error Expected indentation of 4 tabs but found 5 indent
503:1 error Expected indentation of 3 tabs but found 4 indent
504:1 error Expected indentation of 2 tabs but found 3 indent
✖ 9 problems (9 errors, 0 warnings)
8 errors and 0 warnings potentially fixable with the `--fix` option. In addition, you can rebase with the master, as some randomly failing tests have been fixed. Could avoid some build failures, that have nothing to do with this change. |
037b017
to
cbcc304
Compare
Done. It seems like have executed the eslint check in the wrong directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Works fine with different scenarios.
Implement changing of focus of options on keypress - typing letters now allows focusing different options of the ui5-select.
Fixes: #3476