Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-datepicker and ui5-input events` names are inconsistent #365

Closed
ilhan007 opened this issue Apr 25, 2019 · 1 comment · Fixed by #394
Closed

ui5-datepicker and ui5-input events` names are inconsistent #365

ilhan007 opened this issue Apr 25, 2019 · 1 comment · Fixed by #394
Assignees
@ilhan007

Comments

@ilhan007
Copy link
Member

ilhan007 commented Apr 25, 2019 •
edited
Loading

Describe the bug
The ui5-datepicker fires "liveChange", while the ui5-input fires "input" event, which is a bit misleading/confusing for app developers and looks inconsistent.

Expected behaviour
To make the events` names consistent.

Context
SAP-samples/ui5-webcomponents-sample-vue#14
@ilhan007 ilhan007 mentioned this issue Apr 25, 2019
Closed
@pskelin
Copy link
Contributor

pskelin commented Apr 25, 2019

While on the same topic, let's discuss if the input event of the composed element should be stopped. Otherwise the user of the datepicker will receive two input events - one from ui5-datepicker and one from the composed ui5-input.

@ilhan007 ilhan007 self-assigned this May 14, 2019
@ilhan007 ilhan007 mentioned this issue May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(ui5-datepicker): rename event 'liveChange' to 'input' SAP/ui5-webcomponents
2 participants
@pskelin @ilhan007