Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-li-notification-group): visual fixes for right-to-left mode #4354

Merged
merged 1 commit into from
Nov 25, 2021
Merged

fix(ui5-li-notification-group): visual fixes for right-to-left mode #4354

merged 1 commit into from
Nov 25, 2021

Conversation

LidiyaGeorgieva
Copy link
Contributor

  • "collapse" arrow is now pointing down in RTL
  • buttons and status icons are correctly aligned in RTL
  • background is not switching to blue when user taps (on touch device)

Fixes #4255
Fixes #4256
Fixes #4257

Thank you for your contribution! 👏

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@LidiyaGeorgieva
fix(ui5-li-notification-group): visual fixes for right-to-left mode
89628ad 
- "collapse" arrow is now pointing down in RTL
- buttons and status icons are correctly aligned in RTL
- background is not switching to blue when user taps (on touch device)

Fixes #4255
Fixes #4256
Fixes #4257
@LidiyaGeorgieva LidiyaGeorgieva requested review from a team, ilhan007 and fifoosid November 17, 2021 15:06
@ilhan007 ilhan007 merged commit 13b7d68 into master Nov 25, 2021
@ilhan007 ilhan007 deleted the NotificationsFixes branch November 25, 2021 17:16
ndeshev pushed a commit to ndeshev/ui5-webcomponents that referenced this pull request Dec 13, 2021
@LidiyaGeorgieva @ndeshev
fix(ui5-li-notification-group): visual fixes for right-to-left mode (S…
4ab16c6 
…AP#4354)

- "collapse" arrow is now pointing down in RTL
- buttons and status icons are correctly aligned in RTL
- background is not switching to blue when user taps (on touch device)

Fixes SAP#4255
Fixes SAP#4256
Fixes SAP#4257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgimkv georgimkv georgimkv approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@LidiyaGeorgieva @georgimkv @ilhan007