fix: prevent runtime error on malformed custom theme object #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested review from
ilhan007,
fifoosid,
pskelin and
MarcusNotheis
|
I did some more fixes - the errors are reported only once, but this is no longer necessary for your use case. See the 3rd point in the changes list in the PR |
MarcusNotheis
approved these changes
Nov 23, 2021
pskelin
approved these changes
Nov 23, 2021
ilhan007
pushed a commit
that referenced
this pull request
Nov 29, 2021
ndeshev
pushed a commit
to ndeshev/ui5-webcomponents
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Pathproperty of its metadata object is malformed,applyTheme.jsends up callingcreateOrUpdateStylewithundefinedas the first parameter.This failed silently before, as
cssTextcould be a string only. After the recent CSP-related changes,cssTextcan be either a string, or an object. To better reflect this change, thecssTextvariable has been renamed tocssData.Each error (of possible 3) is reported only once during custom theme detection
Most notably, when detecting a custom theme, each of the meta-classes is applied consecutively and tested for. This allows to test for
sapThemeMetaData-Base-baseLibfirst, and only if not found, to look forsapThemeMetaData-UI5-sap-ui-core. This preserves the old behavior.fixes: #4346