Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-badge): center text vertically #4394

Merged
merged 1 commit into from
Nov 29, 2021
Merged

fix(ui5-badge): center text vertically #4394

merged 1 commit into from
Nov 29, 2021

Conversation

georgimkv
Copy link
Contributor

Fixes #4358

@georgimkv georgimkv requested review from ilhan007 and a team November 26, 2021 15:43
@fifoosid fifoosid merged commit e6d0f69 into master Nov 29, 2021
@fifoosid fifoosid deleted the badge_center_text branch November 29, 2021 14:39
ndeshev pushed a commit to ndeshev/ui5-webcomponents that referenced this pull request Dec 13, 2021
@georgimkv @ndeshev
fix(ui5-badge): center text vertically (SAP#4394)
6629254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge: text is not vertically aligned
2 participants
@georgimkv @fifoosid