Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-input): add full keyboard support #4414

Merged
merged 18 commits into from
Dec 15, 2021
Merged

feat(ui5-input): add full keyboard support #4414

merged 18 commits into from
Dec 15, 2021

Conversation

stbodurov
Copy link
Contributor

@stbodurov stbodurov commented Dec 2, 2021

The keyboard specification for the Input is now fully adopted.

Related to: #3090

The keyboard specification for the Input is now fully adopted.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
packages/main/src/Input.js Outdated Show resolved Hide resolved
packages/main/src/Input.js Outdated Show resolved Hide resolved
packages/main/src/Input.js Outdated Show resolved Hide resolved
packages/main/src/Input.js Outdated Show resolved Hide resolved
packages/main/src/Input.js Outdated Show resolved Hide resolved
stbodurov and others added 5 commits December 13, 2021 09:18
Co-authored-by: Simona Rangelova <32678370+simonarangelova@users.noreply.github.com>
Co-authored-by: Simona Rangelova <32678370+simonarangelova@users.noreply.github.com>
Co-authored-by: Simona Rangelova <32678370+simonarangelova@users.noreply.github.com>
Co-authored-by: Simona Rangelova <32678370+simonarangelova@users.noreply.github.com>
Co-authored-by: Simona Rangelova <32678370+simonarangelova@users.noreply.github.com>
@stbodurov stbodurov requested a review from d3xter666 December 13, 2021 07:19
@stbodurov stbodurov merged commit 6133393 into master Dec 15, 2021
@stbodurov stbodurov deleted the inputkh branch December 15, 2021 14:20
@ilhan007
Copy link
Member

Hello @stbodurov it's good to relate the PR to the related issue.

If it's a subtask of the whole as in this case, you can add this to the commit message body:
Related to: #3090

eshpak pushed a commit to eshpak/ui5-webcomponents that referenced this pull request Jan 9, 2022
The keyboard specification for the Input is now fully adopted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants