Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-panel): rotate button counterclockwise in RTL mode #4470

Merged
merged 1 commit into from
Dec 13, 2021
Merged

fix(ui5-panel): rotate button counterclockwise in RTL mode #4470

merged 1 commit into from
Dec 13, 2021

Conversation

niyap
Copy link
Contributor

@niyap niyap commented Dec 10, 2021 •
edited
Loading

FIXES: #3753

ilhan007
ilhan007 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code seems fine to me +1

@niyap niyap merged commit d3f6e39 into SAP:master Dec 13, 2021
@niyap niyap mentioned this pull request Dec 13, 2021
Closed
eshpak pushed a commit to eshpak/ui5-webcomponents that referenced this pull request Jan 9, 2022
@niyap @eshpak
fix(ui5-panel): rotate button counterclockwise in RTL mode (SAP#4470)
eb82e69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@MapTo0 MapTo0 MapTo0 approved these changes

@ndeshev ndeshev Awaiting requested review from ndeshev

@elenastoyanovaa elenastoyanovaa Awaiting requested review from elenastoyanovaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panel: In RTL mode, the arrow is rotated in wrong direction when expanding
3 participants
@niyap @MapTo0 @ilhan007