fix: Breadcrumbs no longer throws an error when empty #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vladitasev, If there are no links the breadcrumbs should remain visible with empty content. If one link is provided it should remain as current selected item (text only) if design is set to Edit: It will be revised in following issue: #4565 Regards, |
nnaydenow
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separator-class="Slash"had been mistakenly identified as aclassattribute by the script that refactored all test pages a while ago and extracted all hard-coded CSS to a separate file@kineticjs Please investigate how Breadcrumbs should look like with no items and one item only. Currently, even with one item, nothing is displayed. If that is not intended, please create an issue or a follow-up change to fix that.
closes: #4562