Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-illustrated-message): Added illustrations to the default set #4587

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

plamenivanov91
Copy link
Contributor

Thank you for your contribution! 👏

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@ilhan007
Copy link
Member

Perhaps these 3 are not ready or finalised as design, could you check them just in case, because these 3 have been requested specifically by the stakeholders

  • success-balloon
  • success-high-five
  • success-checkmark

@plamenivanov91
Copy link
Contributor Author

Perhaps these 3 are not ready or finalised as design, could you check them just in case, because these 3 have been requested specifically by the stakeholders

  • success-balloon
  • success-high-five
  • success-checkmark

I don't see them in our resources share point. Are you sure they are not here but with a different name (for example we have BalloonSky)? Do you know how the mentioned SVGs are supposed to look?

@ilhan007
Copy link
Member

ilhan007 commented Jan 18, 2022

It's possible, here you can find how they look
#3739

Screenshot 2022-01-18 at 14 19 15

Also, sometime ago @nnaydenow has explained that:
"
SuccessBallon" and "CheckMark" illustrations are finished and we are planning to add them soon.
Third one ("HighFive") has only one illustration and it is currently not finished that's why we can't add it at the moment.
"

ilhan007
ilhan007 previously approved these changes Jan 21, 2022
@fifoosid fifoosid merged commit 417bd6a into SAP:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants