fix(ui5-split-button): fix JS error on empty text content #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested review from
fifoosid,
NHristov-sap,
vladitasev and
MarcusNotheis
MarcusNotheis
previously approved these changes
Jan 23, 2022
NHristov-sap
previously approved these changes
Jan 24, 2022
ilhan007
dismissed stale reviews from NHristov-sap and MarcusNotheis
via
870cb64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the default slot is empty, e.g no text is provided, the
this.text[0].textContentthrows an error.Instead, call to
this.textContentis sufficient.Fixes: #4609