Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-dialog): reposition on screen resize #5283

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Conversation

georgimkv
Copy link
Contributor

@georgimkv georgimkv commented May 26, 2022

When the body element is shorter in height than the screen size,
resizing the browser window in height would not trigger a resize
event on the body, and the dialog will not be repositioned.

To solve this case, the dialog has been changed to listen for the resize
event on the window.

Fixes: #5259

When the body element is shorter in height than the screen size,
resizing the browser window in height would not trigger a resize
event on the body, and the dialog will not be repositioned.

To solve this case, the dialog has been changed to listen to the resize
event on the window.

Fixes: #5259
@georgimkv georgimkv requested a review from a team May 26, 2022 12:28
@georgimkv georgimkv force-pushed the dialog_recenter_fix branch from 0a6111d to c032808 Compare May 26, 2022 12:37
@georgimkv georgimkv closed this May 27, 2022
@georgimkv georgimkv reopened this May 27, 2022
@georgimkv georgimkv closed this May 30, 2022
@georgimkv georgimkv reopened this May 30, 2022
@georgimkv georgimkv removed the request for review from a team June 6, 2022 12:44
@georgimkv georgimkv marked this pull request as draft June 6, 2022 12:44
@georgimkv georgimkv marked this pull request as ready for review June 7, 2022 11:30
@georgimkv georgimkv merged commit c2341e8 into main Jun 7, 2022
@georgimkv georgimkv deleted the dialog_recenter_fix branch June 7, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertically resizing window does not recenter the Dialog in 1.3.X
2 participants