Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@zxing throwing source maps warnings for webpack5 #5648

Closed
1 of 4 tasks
Lukas742 opened this issue Aug 9, 2022 · 0 comments · Fixed by #5809
Closed
1 of 4 tasks

@zxing throwing source maps warnings for webpack5 #5648

Lukas742 opened this issue Aug 9, 2022 · 0 comments · Fixed by #5809
Assignees
Labels
dependencies Pull requests that update a dependency file TOPIC Core

Comments

@Lukas742
Copy link
Collaborator

Lukas742 commented Aug 9, 2022

Bug Description

The third party library zxing-js used for the barcode scanner, is throwing source map warnings when used with webpack5. There are two open issues covering this topic (zxing-js/library#512, zxing-js/library#499), but as the library is in maintenance only mode, I don't think they will be resolved soon (if ever).
Since webpack5 is used in create-react-app this will most probably affect most projects using React.
Although, this is just a warning, I thought it was worth mentioning as we received increasing questions and issues about this warning (e.g. SAP/ui5-webcomponents-react#2876).

Steps to Reproduce

  1. Clone this GitHub repo
  2. run npm start or npm run build
  3. see source maps warning

Isolated Example

https://github.com/Lukas742/sourcemaps-issue

Context

  • UI5 Web Components version: 1.6.0
  • Affected component: BarcodeScannerDialog

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: UI5 Web Components for React
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file TOPIC Core
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants