-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui5-shellbar "Expanded" is being read on focus of the search button icon #5674
Comments
Hello @bonniegso, I wasn't able to reproduce the issue via the provided sample nor on local environment by switching to 1.6 release branch. At my side when I inspect the DOM the Could you provide a sample on which the issue could be reproduced or an isolated snipped like this one: Best Regards, |
Hi @unazko , Here is a sample where you can reproduce the issue.https://stackblitz.com/edit/js-6v9yvk?file=index.js,index.html Thanks, |
Hello @SAP/ui5-webcomponents-topic-p could you take a look? The dispatcher could not reproduce it, let's have a try with one more person. Thanks, |
Hi @bonniegso From your latest example we see that you have set the private API The accessibility spec and the component are not implemented considering initially expanded search fileds. Thanks, |
Bug Description
"Search button expanded" is read upon focus of the search button in the shell bar. When the search input is visible by default, this causes confusion because the user did not take any action to expand the search input.
Expected Behavior
The search button should not read "expanded" in its initial state. One suggestion would be to implement the search button as a toggle button https://sap.github.io/ui5-webcomponents/playground/components/ToggleButton/ so that "pressed" and "unpressed" states are read instead of "expanded" and "collapsed" since it is usually expected that expanded content has some sort of text or menu. If this is not possible, then a way to customize or set the aria-expanded value or customize the aria label for the search button would also suffice.
Steps to Reproduce
Context
Priority
The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:
Note: The priority might be re-evaluated by the issue processor.
Stakeholder Info (if applicable)
The text was updated successfully, but these errors were encountered: