fix(ui5-icon): visualize the icons properly in Safari #5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
approved these changes
Sep 30, 2022
dobrinyonkov
approved these changes
Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari, the svg does not occupy 100% of the Icon's height and that causes the issue. The svg needs to take full width and height of the root in order to be visualised correctly. Setting the width and height of the svg to 100%, I tested many different samples and components that use ui5-icon and I did not find any side effects from the change. Something more, the ui5-icon has a predefined width and height of 1rem, so that has to prevent unexpected changes in the svg size.
FIXES: #5842