-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-input): make icons responsive when height is changed #5908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Horizon theme, both in compact and cosy, the icon now is higher than expected and overlap the background image applied to the bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the value states (Warning, Error and Information)? There, the bottom background image has 2px width and the problem still occurs.
packages/main/src/themes/Input.css
Outdated
|
||
:host([value-state]:not([value-state="None"])) .ui5-input-clear-icon-wrapper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue still exist. Now, it is even worse as the icon overlaps 2px of the input field, where with the previous patch set it overlapped 1px.
Following, the way of your implementation, I think the height of the icon has to be calc(100% - 2px) when the value state is Error, Warning or Information.
FIXES: #5314