feat(ui5-switch): provide tooltip property #5954
Conversation
- Application developers are enabled to use the new tooltip property in cases when referecing and external label is not wanted. Fixes: SAP#5552
| * @defaultvalue: "" | ||
| * @public | ||
| * @since 1.9.0 | ||
| */ |
There was a problem hiding this comment.
In the case we need to provide API for setting the tooltip, we often provide a private property, called "title".
And because it's called "title" we operate with the value of the standard HTML "title" attribute. This is done in several components already: see Option, TreeItem, ListItem, SideNavigationItem
/**
* Defines the tooltip of the component.
* @type {string}
* @DefaultValue ""
* @Private
*/
title: {
type: String,
},
There is a "tooltip" in Button, can't recall the reason, but at least initially you can support the native way of setting a tooltip - with the "title" via the private "title" property. In case there is some specific things that requires a separate property, you can always do that.
<ui5-switch title="my cool tooltip"></ui5-switch>Advantages
- native way for setting tooltip
- no public API
- tooltip property can be always added later if required
There was a problem hiding this comment.
On second thought, there might be duplicate reading with Jaws... so yes it may not work for you (you can test it if not already). If that's the case "tooltip" is fine.
There was a problem hiding this comment.
Checked it with JAWS and it's read out twice if we use title. I think we have to stick to the tooltip solution
an external label is not wanted.
Fixes: #5552