Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-list, ui5-li, ui5-li-custom): migrate to TS #6166

Merged
merged 23 commits into from
Dec 20, 2022
Merged

feat(ui5-list, ui5-li, ui5-li-custom): migrate to TS #6166

merged 23 commits into from
Dec 20, 2022

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented Dec 8, 2022

List, ListItemBase, ListItem, StandardListItem, CustomListItem migrated to TypeScript.

  • Introduced new ComponentStylesData type for style of the component and ClassMap type for dynamic classes of the component.

  • Now, slot's type is set to HTMLElement by default

Related: #6080

@nnaydenow nnaydenow changed the title feat(ui5-list): add TypeScript types feat(ui5-list, ui5-li): add TypeScript types Dec 8, 2022
@nnaydenow nnaydenow changed the title feat(ui5-list, ui5-li): add TypeScript types feat(ui5-list, ui5-li, ui5-li-custom): migrate to TS Dec 13, 2022
ilhan007
ilhan007 previously approved these changes Dec 15, 2022
@ilhan007
Copy link
Member

Looks good to me

dobrinyonkov
dobrinyonkov previously approved these changes Dec 16, 2022
@nnaydenow nnaydenow dismissed stale reviews from dobrinyonkov and ilhan007 via c5177db December 20, 2022 08:02
@nnaydenow nnaydenow merged commit 12b3570 into SAP:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants