Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllustratedMessage: message error with double quotes #6187

Closed
sfsf-xweb-sh opened this issue Dec 14, 2022 · 2 comments
Closed

IllustratedMessage: message error with double quotes #6187

sfsf-xweb-sh opened this issue Dec 14, 2022 · 2 comments
Labels
bug This issue is a bug in the code

Comments

@sfsf-xweb-sh
Copy link

Describe the bug
hi, team, for the IllustratedMessage component the message is incorrect.

Isolated Example
the example is comes from your official storybook.

https://sap.github.io/ui5-webcomponents-react/?path=/docs/user-feedback-illustratedmessage--default-story

Also the BeforeSearch, NoData has the same issue.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents-react/?path=/docs/user-feedback-illustratedmessage--default-story
  2. select the IllustratedMessage name with PageNotFound
  3. See message error with double quotes

Expected behavior
The message should be Sorry, we can't find this page

Screenshots
image
image
image

UI5 Web Components for React Information
@ui5/webcomponents version: 1.9.1
@ui5/webcomponents-react version: 1.6.0
Operating System:
Browser: Any

@sfsf-xweb-sh sfsf-xweb-sh added the bug This issue is a bug in the code label Dec 14, 2022
@Lukas742
Copy link
Collaborator

Hi @sfsf-xweb-sh

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Hi colleagues,

for the language code en all apostrophes are duplicated. Strangely this does not apply for en_GB.
You can try it out in our storybook, by selecting a message type with apostrophe and switching the language to "English" (or by simply using this link)
image

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Dec 14, 2022
@nnaydenow
Copy link
Contributor

nnaydenow commented Dec 14, 2022

Hi,

There was a issue with escaping of i18n texts which is fixed in: #6041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants