fix(ui5-range-slider): fire input event with correct values after swapping #6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle swapping resolves #6377 Also fixes the visual bugs with the progress bar during value swap when dragging the handles.
ndeshev
changed the title
vladitasev
approved these changes
Jan 31, 2023
niyap
requested changes
Jan 31, 2023
There was a problem hiding this comment.
The change fixes the issue but introduces a new one as well.
Check the sample "Event Testing Slider". Drag the first handle slowly, swapping it with the other one, notice how the "input" event is fired but the handle is not visualised. It is visualised again two steps after the swap which is not expected.
…pping fix the bug from the testing
…pping Fix change event firing on keyboard interactions and the swapping bug on keyboard triggered swaps
…pping Clean the comment
niyap
approved these changes
Feb 8, 2023
kskondov
pushed a commit
that referenced
this pull request
Feb 10, 2023
…pping (#6385) * fix(ui5-range-slider): fire input event with correct values after handle swapping resolves #6377 Also fixes the visual bugs with the progress bar during value swap when dragging the handles. * fix(ui5-range-slider): fire input event with correct values after swapping fix the bug from the testing * fix(ui5-range-slider): fire input event with correct values after swapping * fix(ui5-range-slider): fire input event with correct values after swapping Fix change event firing on keyboard interactions and the swapping bug on keyboard triggered swaps * fix(ui5-range-slider): fire input event with correct values after swapping Clean the comment * fix(ui5-range-slider): fire input event with correct values after swapping lint * fix(ui5-range-slider): don't fire change event if values are not changed * fix(ui5-range-slider): fire input event with correct values after swapping fix typos
ilhan007
pushed a commit
that referenced
this pull request
Feb 15, 2023
…pping (#6385) * fix(ui5-range-slider): fire input event with correct values after handle swapping resolves #6377 Also fixes the visual bugs with the progress bar during value swap when dragging the handles. * fix(ui5-range-slider): fire input event with correct values after swapping fix the bug from the testing * fix(ui5-range-slider): fire input event with correct values after swapping * fix(ui5-range-slider): fire input event with correct values after swapping Fix change event firing on keyboard interactions and the swapping bug on keyboard triggered swaps * fix(ui5-range-slider): fire input event with correct values after swapping Clean the comment * fix(ui5-range-slider): fire input event with correct values after swapping lint * fix(ui5-range-slider): don't fire change event if values are not changed * fix(ui5-range-slider): fire input event with correct values after swapping fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6377
Resolves #6413
Fixes the visual bugs with the progress bar during value swap when dragging the handles.
Fixes change event firing on keyboard interactions and the swapping bug on keyboard triggered swaps.
Fixed bug where change event is fired after mouse interaction even if the initial values are not changed.
Note: The swapping of the values is no longer executed on finalized interaction (mouseup, keyup), but immediately after the start value is bigger than the end one.