Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table - The style of divider line between header and content of the table is different when there is data and no data #6465

Closed
kilgharsap opened this issue Feb 10, 2023 · 2 comments · Fixed by #6495
Assignees
Labels
bug This issue is a bug in the code Low Prio Table TOPIC RL

Comments

@kilgharsap
Copy link

kilgharsap commented Feb 10, 2023

Describe the bug
The style of divider line between header and content of the table is different when there is data and no data. The divider line is much thicker when there is no data

Screenshots
Screenshot 2023-02-10 at 9 20 19 AM

UI5 Web Components for React Information
@ui5/webcomponents version:
@ui5/webcomponents-react version:
Operating System:
Browser:

Additional context
Add any other context about the problem here.

@kilgharsap kilgharsap added the bug This issue is a bug in the code label Feb 10, 2023
@kilgharsap kilgharsap changed the title ComponentName: Description ComponentName: Table - The style of divider line between header and content of the table is different when there is data and no data Feb 10, 2023
@MarcusNotheis MarcusNotheis changed the title ComponentName: Table - The style of divider line between header and content of the table is different when there is data and no data Table - The style of divider line between header and content of the table is different when there is data and no data Feb 11, 2023
@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Feb 11, 2023
@s-todorova
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rl,

Please check the image above. Per my analysis, the thicker line in the no data table comes from the following style:
.ui5-table-no-data-row {
...
border-top: 1px solid var(--sapList_BorderColor);
}

Could you please check if that is the expected visualization?

Thank you in advance,
Siyana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Low Prio Table TOPIC RL
Projects
Status: Completed
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

6 participants