fix(theming): fix icons version detection for custom theme (built via the ThemeDesigner) #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ThemeDesigner) Related to: #6758
nnaydenow
approved these changes
Mar 30, 2023
didip1000
pushed a commit
that referenced
this pull request
Apr 4, 2023
…the ThemeDesigner) (#6815) Currently, for older themes (sap_belize, sap_fiori_3) we display old icon fonts, while for sap_horizon - the latest icon fonts. This applies for all icon collections. And, to do that we check if the current theme is part of the sap_horizon theme family or not. However, once an app is using custom theme, the current theme has a custom theme and by default we will enforce the old icon fonts, because the custom theme name won't match "sap_horizon". With this change, when the current theme name is not part of the built-in theme families, we now look for an custom theme and check the base theme that the custom theme is built upon: rename isThemeFamily to isLegacyThemeFamily and adopt it in the code (all isThemeFamily("sap_horizon") calls are replaced with !isLegacyThemeFamily) isLegacyThemeFamily now checks the baseTheme of the custom theme if present add test (one when built-in theme is set and when theme designer custom theme is used) Related to: #6758
NHristov-sap
pushed a commit
that referenced
this pull request
May 4, 2023
…the ThemeDesigner) (#6815) Currently, for older themes (sap_belize, sap_fiori_3) we display old icon fonts, while for sap_horizon - the latest icon fonts. This applies for all icon collections. And, to do that we check if the current theme is part of the sap_horizon theme family or not. However, once an app is using custom theme, the current theme has a custom theme and by default we will enforce the old icon fonts, because the custom theme name won't match "sap_horizon". With this change, when the current theme name is not part of the built-in theme families, we now look for an custom theme and check the base theme that the custom theme is built upon: rename isThemeFamily to isLegacyThemeFamily and adopt it in the code (all isThemeFamily("sap_horizon") calls are replaced with !isLegacyThemeFamily) isLegacyThemeFamily now checks the baseTheme of the custom theme if present add test (one when built-in theme is set and when theme designer custom theme is used) Related to: #6758
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Jun 20, 2023
…the ThemeDesigner) (#6815) Currently, for older themes (sap_belize, sap_fiori_3) we display old icon fonts, while for sap_horizon - the latest icon fonts. This applies for all icon collections. And, to do that we check if the current theme is part of the sap_horizon theme family or not. However, once an app is using custom theme, the current theme has a custom theme and by default we will enforce the old icon fonts, because the custom theme name won't match "sap_horizon". With this change, when the current theme name is not part of the built-in theme families, we now look for an custom theme and check the base theme that the custom theme is built upon: rename isThemeFamily to isLegacyThemeFamily and adopt it in the code (all isThemeFamily("sap_horizon") calls are replaced with !isLegacyThemeFamily) isLegacyThemeFamily now checks the baseTheme of the custom theme if present add test (one when built-in theme is set and when theme designer custom theme is used) Related to: #6758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for older themes (
sap_belize,sap_fiori_3) we display old icon fonts, while forsap_horizon- the latest icon fonts. This applies for all icon collections. And, to do that we check if the current theme is part of thesap_horizontheme family or not. However, once an app is using custom theme, the current theme has a custom theme and by default we will enforce the old icon fonts, because the custom theme name won't match "sap_horizon".With this change, when the current theme name is not part of the built-in theme families, we now look for an custom theme and check the base theme that the custom theme is built upon.
isThemeFamilytoisLegacyThemeFamilyand adopt it in the code (all isThemeFamily("sap_horizon") calls are replaced with !isLegacyThemeFamily)isLegacyThemeFamilynow checks thebaseThemeof the custom theme if presentRelated to: #6758