Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-checkbox): adjusted to new Horizon theme specification #6951

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

plamenivanov91
Copy link
Contributor

No description provided.

@plamenivanov91 plamenivanov91 requested a review from kgogov April 25, 2023 16:58
@ilhan007
Copy link
Member

Could you also add some before/after screenshots of the checkbox so one can grasp the Horizon update by looking at the PR description

@plamenivanov91
Copy link
Contributor Author

Could you also add some before/after screenshots of the checkbox so one can grasp the Horizon update by looking at the PR description

Here are the noticeable implemented differences:
Check_Box_Visual Design.pdf
Check_Box_Interaction Design.pdf

@plamenivanov91 plamenivanov91 requested a review from kgogov April 26, 2023 13:38
Copy link
Member

@kgogov kgogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@plamenivanov91 plamenivanov91 merged commit 553d0bd into SAP:main Apr 27, 2023
NHristov-sap pushed a commit that referenced this pull request May 4, 2023
* feat(ui5-checkbox): adjusted to new Horizon theme specification
@petyabegovska
Copy link
Collaborator

Relates to #7000

PetyaMarkovaBogdanova pushed a commit that referenced this pull request Jun 20, 2023
* feat(ui5-checkbox): adjusted to new Horizon theme specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants