Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page: Bad performance - content flicker #7120

Closed
1 task done
C3ntraX opened this issue May 30, 2023 · 7 comments
Closed
1 task done

Page: Bad performance - content flicker #7120

C3ntraX opened this issue May 30, 2023 · 7 comments

Comments

@C3ntraX
Copy link

C3ntraX commented May 30, 2023

Describe the bug

The content-padding of the page component is really bad.
If you are using multiple pages and switch betweeen them, the content is flickering extremly.

See the gif and the codesandbox.

Im using the Table component but its also with all other components.

Isolated Example

https://codesandbox.io/p/sandbox/page-bad-performance-e1810k?file=%2Fsrc%2FApp.tsx%3A42%2C16

Reproduction steps

...

Expected Behaviour

No response

Screenshots or Videos

The gif wasnt able to capture every flicker. Use the codesandbox instead but the flicker is for every page change.

GIF 30 05 2023 14-09-58

UI5 Web Components for React Version

1.15.1

UI5 Web Components Version

1.13.0

Browser

Chrome

Operating System

Windows

Additional Context

No response

Relevant log output

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@C3ntraX C3ntraX added the bug This issue is a bug in the code label May 30, 2023
@Lukas742
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react May 30, 2023
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-assigned this May 30, 2023
@C3ntraX
Copy link
Author

C3ntraX commented May 30, 2023

Other examples. Every pages is flickering (Not all visible in GIF)

GIF 30 05 2023 15-06-56

@Lukas742
As soon as Im using a native React Page implementation there is no flickering.

Table headers also flicker. Even without the "Page" component.

@C3ntraX
Copy link
Author

C3ntraX commented May 30, 2023

Here is a Table header withouth the Page component:

GIF 30 05 2023 15-12-59

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova added Performance and removed bug This issue is a bug in the code labels May 31, 2023
@PetyaMarkovaBogdanova
Copy link
Contributor

Hi team,
can you, please, check where this flickering is coming from?
It can be reproduce with replacing the Page with an ordinary div element (https://codesandbox.io/p/sandbox/page-bad-performance-forked-srsllj?file=%2Fsrc%2FApp.tsx%3A41%2C9)
and by replacing the ui5-table with simple table. (https://codesandbox.io/p/sandbox/page-bad-performance-forked-n2swhb?file=%2Fsrc%2FApp.tsx%3A33%2C41)

Kind regards,
Petya Markova.
(UI5 WC Dispatcher)

@MapTo0
Copy link
Member

MapTo0 commented Jul 29, 2024

Hey @C3ntraX

Could you please check if the issue is resolved with version 2.0?

Best Regards!
Martin

Copy link

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

@github-actions github-actions bot added the Stale label Aug 20, 2024
Copy link

Hello, everyone! The issue has been inactive for 28 days, so I am closing the issue.

@github-project-automation github-project-automation bot moved this from In progress to Completed in Maintenance - Topic RL Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

6 participants