fix(framework): prioritize external fonts over locally installed #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
approved these changes
Jun 13, 2023
nnaydenow
pushed a commit
that referenced
this pull request
Jun 13, 2023
- Fetch the latest font file and then fallback to locally installed. - reorder font source origin url() and local() and make url first (previously local() used to be first and then followed by url()), so the latest version of the woff2 file will be fetched, and if this fails it will fallback to locally installed font with the same name. This is also the order in OpenUI5: https://github.com/SAP/openui5/blob/master/src/themelib_sap_horizon/src/sap/ui/core/themes/sap_horizon/shared.less#L259 - the path to the external source is slightly changed: sap/ui/core/themes/sap_fiori_3 changed to sap/ui/core/themes/sap_horizon, although it should be the same - added test pages Fixes: #7177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch the latest font file and then fallback to locally installed.
reorder font source origin
url()andlocal()and makeurlfirst (previouslylocal()used to be first and then followed byurl()), so the latest version of the woff2 file will be fetched, and if this fails it will fallback to locally installed font with the same name.This is also the order in OpenUI5: https://github.com/SAP/openui5/blob/master/src/themelib_sap_horizon/src/sap/ui/core/themes/sap_horizon/shared.less#L259
the path to the external source is slightly changed: sap/ui/core/themes/sap_fiori_3 changed to sap/ui/core/themes/sap_horizon, although it should be the same
added test pages
Fixes: #7177