Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-upload-collection): correct visualization of "mode" property #7252

Merged
merged 7 commits into from
Jul 21, 2023
Merged

fix(ui5-upload-collection): correct visualization of "mode" property #7252

merged 7 commits into from
Jul 21, 2023

Conversation

LidiyaGeorgieva
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva commented Jun 23, 2023 •
edited
Loading

Fixes #7111

dimovpetar
dimovpetar requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@dimovpetar dimovpetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Cursor should be "pointer" for selectable items
  2. Mode "Delete" shouldn't have effect. By default the delete icon of every item is shown and it can be hidden through "hideDeleteButton"

@LidiyaGeorgieva
Copy link
Contributor Author

LidiyaGeorgieva commented Jul 6, 2023 •
edited
Loading

  1. Cursor should be "pointer" for selectable items
  2. Mode "Delete" shouldn't have effect. By default the delete icon of every item is shown and it can be hidden through "hideDeleteButton"
  1. Done
  2. Please check again, I can't reproduce the reported issue

dimovpetar
dimovpetar previously requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@dimovpetar dimovpetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In Fiori 3 themes, during selection, the color of the file name, thumbnail and the default slot has to be changed. Currently it looks like this:
    image

@LidiyaGeorgieva
Copy link
Contributor Author

  • In Fiori 3 themes, during selection, the color of the file name, thumbnail and the default slot has to be changed. Currently it looks like this:
    image

Fixed!

@LidiyaGeorgieva LidiyaGeorgieva merged commit 9ca02dd into main Jul 21, 2023
@LidiyaGeorgieva LidiyaGeorgieva deleted the UploadCollection branch July 21, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimovpetar dimovpetar dimovpetar approved these changes

@TeodorTaushanov TeodorTaushanov Awaiting requested review from TeodorTaushanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-upload-collection: SingleSelectBegin, SingleSelectEnd, MultiSelect and SingleSelect modes don't work
2 participants
@LidiyaGeorgieva @dimovpetar