Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-split-button): adapt visual design with new parameters #7584

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Sep 13, 2023

Rework on the Split Button visual design in order to be complient with VD Spec in all themes and rtl direction as well.

Copy link
Contributor

@tsanislavgatev tsanislavgatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quartz - on press arrow button or action button in transparent button, the arrow disappear. That's not by spec.
belize - the same ^
on hover split button transparent in horizon is also broken. If you hover only arrow, full button gets hovered

@hinzzx hinzzx merged commit 28997c8 into main Sep 18, 2023
@hinzzx hinzzx deleted the split-btn-fix branch September 18, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants