Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-combobox): update picker items while open #7937

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Nov 29, 2023

FIXES: #7011

@MapTo0 MapTo0 requested review from niyap and elenastoyanovaa and removed request for niyap November 29, 2023 08:40
@ilhan007
Copy link
Member

ilhan007 commented Nov 29, 2023

Hi Marti @MapTo0 , there is another issues that sounds similar
#7776

The author is trying to call blur so the dropdown closes, because items are not updated while dropdown is open.
However, it's not only for the ComboBox, but for the MultiComboBox as well.

Could you consider the MultiComboBox case as well - could be in another PR, it's just to let you know.

@timogeib
Copy link

timogeib commented Dec 1, 2023

@ilhan007 Just to clarify.
I do not "TRY" to call blur() to close the options. I NEED to, so that I force the options to close after loading, because the options list does not refresh. Calling blur() is the workaround, so the user NEEDS to repoen the options that are then updated.

@ilhan007
Copy link
Member

ilhan007 commented Dec 1, 2023

@ilhan007 Just to clarify. I do not "TRY" to call blur() to close the options. I NEED to, so that I force the options to close after loading, because the options list does not refresh. Calling blur() is the workaround, so the user NEEDS to repoen the options that are then updated.

@timogeib yes, we are aware of that, as you can see, the PR clearly states: "fix(ui5-combobox): update picker items while open", so that you wont need to even call blur or any other method.

@MapTo0 MapTo0 merged commit 8f99f8d into main Dec 7, 2023
6 checks passed
@MapTo0 MapTo0 deleted the combobox-dynamic-items branch December 7, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ComboBox] combobox drop down does not update dynamically
4 participants