-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Using keyboard down button, item below the previously selected item should be selected but not the first item in the dropo-down #8238
Comments
Hello @sanketzad, I am not able to reproduce the behaviour you have described. Thanks and Regards, |
Hi, @yanaminkova , I have created an example under the title Please refer to the example here. And also, I request to check with the design team whether the request is aligned with design standard. With regards, |
Hello @SAP/ui5-webcomponents-topic-rl, Please have a look at this feature request regarding It seems that the current implementation of those components works in a way that on arrow down, always the first item in the drop down is selected, no matter whether already there is selected item or not. Thanks and Kind regards, |
Hi @sanketzad , As this is how the ComboBox component is designed and is currently working as specified, can you please raise a feature request to the Central Design team as per the Federated Process so they can have a look into it and provide their statement. Currently, the behavior, follows the logic that while typing, no matter if the picker is opened, the focus is in the input field and not in the list. Best Regards, |
Hi, @hristop , I had the opportunity to go through the Fiori design guidelines with the help of Georg, who is a lead designer. I have to share some of the information that we found out about the keyboard The aforementioned specification can be downloaded or viewed here. The above mentioned snippet is on page 107. With the "next matching item," I would personally understand the next item that fits my current input, not the first one. Could you kindly clarify if you adhere to different specs, as everything I've said is part of the Fiori design guidelines? WIth regards, |
Hi @sanketzad , This exact behavior has been confirmed by the ACC expert, who created the document you are referring. The focus in the mentioned components is inside of the input field, not in the list. So when you type in, additional filtration is achieved. This works a bit different in the ui5-combobox than in the ui5-multi-combobox components, but for your case the result is the same - focus in the input. You can check page 183, which contains the keyboard specification for the combo box in particular. Hope this makes things more clear. Best Regards, |
Hi @hristop , The recent discussion with the ACC team and Georg agreed that this is bug and the behaviour of the With regards, |
There is internal P1 BLI created for the issue: FIORITECHP1-31509 |
Hi, We are done with the implementation of this feature with #10166. Best Regards, |
Feature Request Description
Impacted components:
ui5-combobox
andui5-multi-combobox
The user has typed a character, and typeahead is displayed in the input when the drop-down is open, leading to the selection of the typeahead list item. At this stage, if the user decides to navigate through the list by using the keyboard, i.e., the down and up arrow buttons, the selection should be done on the next and previous list item, referring to the already selected item. But not selecting the first item (even if another item is selected) when the down arrow is pressed.
Please refer to the snippets below:
C
is typed:Pressing the
Down
arrow, it should ideally selectFrance
, instead it selects the first item in the list, i.e.,South Africa
.Proposed Solution
The drop-down is open, and a list item is selected. When pressing the
Down
orUp
arrow keys, it should select the previous or next item, referring to the already selected item. But it should not start with the first item on the list.Proposed Alternatives
No response
Organization
Ariba
Additional Context
No response
Priority
None
Privacy Policy
The text was updated successfully, but these errors were encountered: