Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TabContainer]: TabContainer has focus issues in small screen #8252

Closed
1 task done
yzy415 opened this issue Feb 7, 2024 · 3 comments
Closed
1 task done

[TabContainer]: TabContainer has focus issues in small screen #8252

yzy415 opened this issue Feb 7, 2024 · 3 comments
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RD

Comments

@yzy415
Copy link

yzy415 commented Feb 7, 2024

Bug Description

On a mobile screen, e.g., 390X844, the tabs except the first one will be grouped into the overflow button.

  1. The user cannot navigate to the overflow button using the tab key.
  2. Even if he uses the arrow key to the overflow button, focus is lost after the button is clicked.
image

Affected Component

TabContainer

Expected Behaviour

  1. The user can navigate to the overflow button using the tab key.
  2. Focus should be set on the first tab option when the list of tab options is opened

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-tabcontainer--docs

Steps to Reproduce

  1. Toggle the device toolbar in devTools
  2. Click the overflow button using the keyboard
  3. You will see there is no focus set when the list of tab options is opened

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@yzy415 yzy415 added the bug This issue is a bug in the code label Feb 7, 2024
@yanaminkova yanaminkova self-assigned this Feb 7, 2024
@yanaminkova
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-b,

It seems that on mobile device, no focus is set when the list of tab options of the ui5-tabcontainer is opened.

Steps to Reproduce:

  1. Open https://sap.github.io/ui5-webcomponents-react/?path=/story/layouts-floorplans-tabcontainer--default
  2. Toggle the device toolbar in devTools
  3. Click the overflow button
    => no focus is set when the list of tab options is opened.

Could you please have a look at it?

Thanks and Kind regards,
Yana

@LidiyaGeorgieva
Copy link
Contributor

Note: This is part of bigger topic for visual focus on mobile: FIORITECHP1-17583.

Related to: #8250

@dimovpetar
Copy link
Contributor

Hello @yzy415 ,

  1. The user cannot navigate to the overflow button using the tab key.

This behavior is expected. You can reach the "Show More" button only with the arrow keys.

  1. Even if he uses the arrow key to the overflow button, focus is lost after the button is clicked.

This issue is fixed with 27b522f and downported to branch rel-1.24 with 58d65bc.

Best regards,
Petar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RD
Projects
Status: Completed
Development

No branches or pull requests

6 participants