Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IllustratedMessage]: content is vertically stretched instead of centered #8702

Closed
1 task done
kozubikmichal opened this issue Apr 9, 2024 · 2 comments
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code

Comments

@kozubikmichal
Copy link

Bug Description

Since the new UI5 Web Components version 1.23.1 the IllustratedMessage component is not using the available space properly. In previous version (1.22.0) the content was centered and the illustration + text were right under each other.

In 1.23.1 there's a gap between the illustration and text depending on the size of the container. I believe this is not intentional, as it would require the host app to always take care of that, which is inconsistent with previous behavior

Affected Component

No response

Expected Behaviour

Content should be centered with no gap between the illustration and texts (same behavior as in prev version)

Isolated Example

https://stackblitz.com/edit/vitejs-vite-hht5hq?file=src/App.tsx

Steps to Reproduce

  1. Open the attached sandbox (it's using React wrappers, but the issue is the same)
  2. See the rendered output

Log Output, Stack Trace or Screenshots

image

Priority

None

UI5 Web Components Version

1.23.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@kozubikmichal kozubikmichal added the bug This issue is a bug in the code label Apr 9, 2024
@niyap niyap self-assigned this Apr 9, 2024
@niyap
Copy link
Contributor

niyap commented Apr 9, 2024

Hello @kozubikmichal,

Thanks for sharing your findings!
Actually, the issue was already reported and fixed with the following PR: #8566
You can test it using UI5 Web Components version 1.24.0

Kind Regards,
Niya

@niyap niyap closed this as completed Apr 9, 2024
@kozubikmichal
Copy link
Author

Hi @niyap
thanks for the info, we'll give it a try!

Regards
Michal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code
Projects
None yet
Development

No branches or pull requests

2 participants