Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-menu-item): add accessibility attributes #9333

Merged
merged 6 commits into from
Jul 8, 2024
Merged

feat(ui5-menu-item): add accessibility attributes #9333

merged 6 commits into from
Jul 8, 2024

Conversation

NHristov-sap
Copy link
Contributor

This PR introduces new property accessibilityAttributes in ui5-menu-item component.

It has 2 properties that affect the accessibility attributes of the menu item:

role - can be used to change the devault menuitem role to something different (for example menuitemcheckbox) ariaKeyShortcuts - can be used to add aria-keyshortcuts attribute value to an item that has a shortcut key defined.

BGSOFUIBALKAN-8351
BGSOFUIBALKAN-8315

@NHristov-sap NHristov-sap added enhancement New feature or request ACC 2.0 labels Jun 28, 2024
@NHristov-sap NHristov-sap self-assigned this Jun 28, 2024
@NHristov-sap NHristov-sap requested a review from dobrinyonkov July 1, 2024 11:26
unazko
unazko approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the change with the screen reader. Everything is readout like expected.

dobrinyonkov
dobrinyonkov approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@dobrinyonkov dobrinyonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

nnaydenow
nnaydenow requested changes Jul 8, 2024
View reviewed changes
packages/main/src/MenuItem.ts Outdated Show resolved Hide resolved
@NHristov-sap NHristov-sap merged commit 74782e6 into main Jul 8, 2024
10 checks passed
@NHristov-sap NHristov-sap deleted the BL_menuitem_acc branch July 8, 2024 07:48
@NHristov-sap NHristov-sap mentioned this pull request Jul 8, 2024
Merged
NHristov-sap added a commit that referenced this pull request Jul 8, 2024
@NHristov-sap
docs(ui5-menu-item): update 09-accessibility.md (#9410)
7f9ed2a 
The Accessibility documentation is being updated with changes introduced by PR #9333 

* `accessibilityAttributes` property introduced in `ui5-menu-item` component

Related to: #9333
@DMihaylova DMihaylova mentioned this pull request Jul 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow approved these changes

@dobrinyonkov dobrinyonkov dobrinyonkov approved these changes

@unazko unazko unazko approved these changes

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees

@NHristov-sap NHristov-sap

Labels
2.0 ACC enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NHristov-sap @tsanislavgatev @unazko @dobrinyonkov @nnaydenow