fix(ui5-combobox): remove the cloning of the value state message #9384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoletavnv
requested changes
Jul 4, 2024
There was a problem hiding this comment.
I noticed that when a value state message has a link, the link can not be clicked because the value state popup is closing (with the items picker it works fine). The issue is in the _focusout method - there is a check if the item to be focused is contained in the items picker or in the vsm popup. Now the value state is not cloned in the popup, the variable "focusedOutToValueState" is always false and the popup closes before the link is actually clicked - lines 524-530
fix value state message link
nikoletavnv
approved these changes
Jul 5, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #9347