Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DynamicSideContent]: [Problem when used with Wizard] #9462

Closed
1 task done
DamyanKolev opened this issue Jul 10, 2024 · 3 comments · Fixed by #9642
Closed
1 task done

[DynamicSideContent]: [Problem when used with Wizard] #9462

DamyanKolev opened this issue Jul 10, 2024 · 3 comments · Fixed by #9642
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC B

Comments

@DamyanKolev
Copy link

Describe the bug

DynamicSideContent does not work properly when it is a child component of the Wizard, the problem is that side content it always sits below the main content regardless of the resolution.

Isolated Example

https://stackblitz.com/edit/github-6r86cw?file=src%2FApp.tsx

Reproduction steps

No response

Expected Behaviour

Expected_Behaviour

Screenshots or Videos

No response

UI5 Web Components for React Version

1.29.3

UI5 Web Components Version

1.24.5

Browser

Chrome, Edge

Operating System

Windows

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@DamyanKolev DamyanKolev added the bug This issue is a bug in the code label Jul 10, 2024
@Lukas742
Copy link
Collaborator

Hi @DamyanKolev

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi colleagues,

here you can find an example showing the described issue using ui5-webcomponents without our wrapper or React: https://stackblitz.com/edit/github-fcfk3z?file=index.html,main.js

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jul 11, 2024
@TeodorTaushanov
Copy link
Member

Hi @SAP/ui5-webcomponents-topic-rl, can you check this issue?

@MapTo0 MapTo0 moved this from New Issues to In progress in Maintenance - Topic RL Jul 22, 2024
@MapTo0 MapTo0 self-assigned this Jul 22, 2024
@MapTo0 MapTo0 added TOPIC B and removed TOPIC RL labels Jul 22, 2024
@MapTo0
Copy link
Member

MapTo0 commented Jul 22, 2024

Hello Colleagues,

Could you please change this getter

You need to call getBoundingClientRect().width instead of clientWidth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Status: Completed
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

5 participants