fix(ui5-special-date): add visual representation for Working/NonWorking types #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
reviewed
Jul 26, 2024
tsanislavgatev
approved these changes
Aug 12, 2024
hinzzx
added a commit
that referenced
this pull request
Aug 12, 2024
…ng types (#9524) Previously, when adding a `SpecialCalendarDate` to the `Calendar` component and specifying the public types `Working` and `NonWorking`, these settings were not properly applied. For example, setting a `Working` type to a weekend day did not visually reflect that the day was designated as a working day and vice versa for `NonWorking` type. With this change we resolve that issue, ensuring that the specified types (`Working` and `NonWorking`) now take effect as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when adding a
SpecialCalendarDateto theCalendarcomponent and specifying the public typesWorkingandNonWorking, these settings were not properly applied.For example, setting a
Workingtype to a weekend day did not visually reflect that the day was designated as a working day and vice versa forNonWorkingtype.With this change we resolve that issue, ensuring that the specified types (
WorkingandNonWorking) now take effect as intended.Fixes: #9216