Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-split-button): provide aria attributes for the arrow button #9598

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Jul 31, 2024

  • Add aria-haspopup and title attributes to the arrow button.

Fixes: #9295

@unazko unazko requested a review from elenastoyanovaa July 31, 2024 08:42
unazko added 3 commits August 1, 2024 09:59
@unazko unazko changed the title fix(ui5-split-button): provide accessibilityAttributes API fix(ui5-split-button): provide aria attributes for the arrow button Aug 1, 2024
@unazko unazko marked this pull request as ready for review August 1, 2024 12:32
@unazko unazko self-assigned this Aug 2, 2024
@unazko unazko merged commit 2af2cf2 into SAP:main Aug 5, 2024
10 checks passed
unazko added a commit to unazko/ui5-webcomponents that referenced this pull request Aug 6, 2024
…AP#9598)

- Add "aria-haspopup" and title attributes to the arrow button.

Fixes: SAP#9295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【SF】【A11y】[SplitButton]: [Missing aria-label for arrow button in splitButton]
2 participants