Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-textarea): focus outline and border overlapping in readonly textarea #9817

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

tw4
Copy link
Contributor

@tw4 tw4 commented Sep 4, 2024

Related to Issue #9741 (issue 2)

Hello @nnaydenow,

You had already reviewed this PR request, and I opened a new PR for a cleaner version. I made the changes you requested. Thank you.

Best regards,
tw4

@nnaydenow nnaydenow changed the title fix(textarea): Focus Outline Touching Borders in Readonly Textarea fix(ui5-textarea): focus outline and border overlapping in readonly textarea Sep 4, 2024
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw4, thank you for your contribution!

@tw4
Copy link
Contributor Author

tw4 commented Sep 4, 2024

Thank you very much, it was very exciting for me. ✨️✨️

@nnaydenow nnaydenow merged commit ea8f751 into SAP:main Sep 5, 2024
10 checks passed
@tw4 tw4 deleted the fix-textarea-focus branch September 27, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants