Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-popover): correct opacity #9839

Merged
merged 4 commits into from
Sep 16, 2024
Merged

fix(ui5-popover): correct opacity #9839

merged 4 commits into from
Sep 16, 2024

Conversation

kskondov
Copy link
Contributor

@kskondov kskondov commented Sep 10, 2024

The background of the modal popover backdrop was black which made the context page not visible
so opacity was added to grey out the background

Fixes: #9823

The background of the modal popover was black
which made the context page not visible
so opacity was added to grey out the background
@kskondov kskondov requested a review from a team September 10, 2024 12:00
Adds high contrast themes parameters
Use only one parameter for popup components
@@ -30,6 +30,7 @@
@import "./MessageStrip-parameters.css";
@import "./Panel-parameters.css";
@import "../base/Popover-parameters.css";
@import "./PopupBlockLayer-parameters.css";
@import "./PopupsCommon-parameters.css";
@import "../base/PopupBlockLayer-parameters.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove @import "../base/PopupBlockLayer-parameters.css";

Remove unnecessary imports
@kskondov kskondov merged commit 371c547 into main Sep 16, 2024
10 checks passed
nowakdaniel pushed a commit that referenced this pull request Sep 25, 2024
The background of the modal popover was black which made the context page not visible.
So opacity was added to grey out the background

Fixes: #9823
@nnaydenow nnaydenow deleted the popover-modal-opacity branch October 24, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-popover]: Popover with modal attribute turns background black
2 participants