feat(ui5-dynamic-page-title): implement snapped title on mobile #9898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgogov
force-pushed
the
feat-dp-snapped-title-on-mobile
branch
2 times, most recently
from
4c95948 to
d61f6d6
Compare
kgogov
force-pushed
the
feat-dp-snapped-title-on-mobile
branch
3 times, most recently
from
8fbc626 to
a2bb1f1
Compare
plamenivanov91
requested changes
Sep 25, 2024
plamenivanov91
requested changes
Sep 25, 2024
- Introduced `snappedTitleOnMobile` property to display a simplified title on mobile when the header is snapped. - Added `snappedTitleOnMobileText` to define the text for the mobile-specific snapped title. - This feature optimizes title display on small screens, improving mobile usability. - Clicking the snapped title on mobile expands the header. - On non-mobile devices, the standard title is displayed, ignoring the mobile-specific title.
- Addressed review comments by changing the implementation of the snapped title on mobile. - Replaced properties with a slot for better flexibility and maintainability.
kgogov
force-pushed
the
feat-dp-snapped-title-on-mobile
branch
from
381cc8f to
22e26e1
Compare
…bile Refactored the implementation to pass the "snappedTitleOnMobile" state from parent to child. This change ensures proper state management, addressing previous review comments.
kgogov
force-pushed
the
feat-dp-snapped-title-on-mobile
branch
from
22e26e1 to
982ec0a
Compare
plamenivanov91
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We have enhanced the
ui5-dynamic-page-titlecomponent to improve the user experience on mobile devices when theDynamicPageTitleis in its collapsed (snapped) state. You can now display a simplified, single-line title specifically designed for mobile screens. This feature optimizes the use of limited screen space on mobile devices by showing a concise title that remains always visible.New Slot
snappedTitleOnMobileui5-titlecomponent) that will be displayed as the title on mobile devices when the header is in its snapped state. The content set in this slot overrides other title content during the snapped state on mobile devices.Usage
To utilize this feature, place a
ui5-titleinto thesnappedTitleOnMobileslot of theui5-dynamic-page-titlecomponent. This content will be displayed on mobile devices when the header is snapped.Example