fix(ui5-list): growing button loading aligned with visual spec #9977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new visual spec mandates that when we have growing with button there shouldn't be busy indicator overlay on top of the whole list but a small one next to "More" text without blocking the rest of the list.
NakataCode
approved these changes
Oct 7, 2024
plamenivanov91
added a commit
to plamenivanov91/ui5-webcomponents
that referenced
this pull request
Oct 17, 2024
With SAP#9977 change we started rendering the busy indicator next to the growing text. This introduced an issue where we align the growing text slightly to the right of the busy indicator but before the busy indicator is actually shown. This fix fixes the issue and the growing text is centered before showing the busy indicator.
plamenivanov91
added a commit
that referenced
this pull request
Oct 18, 2024
With #9977 change we started rendering the busy indicator next to the growing text. This introduced an issue where we align the growing text slightly to the right of the busy indicator but before the busy indicator is actually shown. This fix fixes the issue and the growing text is centered before showing the busy indicator. Fixes: #10047
kgogov
pushed a commit
that referenced
this pull request
Oct 30, 2024
With #9977 change we started rendering the busy indicator next to the growing text. This introduced an issue where we align the growing text slightly to the right of the busy indicator but before the busy indicator is actually shown. This fix fixes the issue and the growing text is centered before showing the busy indicator. Fixes: #10047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new visual spec mandates that when we have growing with button there shouldn't be busy indicator overlay on top of the whole list but a small one next to "More" text without blocking the rest of the list.