Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element.syntax.openBody range does not always exist for partially valid elements #51

Closed
bd82 opened this issue Nov 28, 2019 · 1 comment
Labels

Comments

@bd82
Copy link
Member

bd82 commented Nov 28, 2019

The second and third propertyValue would not have an ``openBody` range.

<Record Type="UI.DataPointType">
    <PropertyValue Property="Value" Path="Price"/>
    <PropertyValue 
    <PropertyValue  attrib1="3"
</Record>

We should "guess" and approximate openBody range which continues until the next
following textual component

Perhaps we should mark that this openBody has been guessed, e.g using another property possibleOpenBody.

@bd82 bd82 added the AST label Nov 28, 2019
@bd82 bd82 closed this as completed in 8ce840d Dec 8, 2019
@bd82
Copy link
Member Author

bd82 commented Dec 8, 2019

Added attributesRange and guessedAttributesRange properties to the AST to handle this scenario.

These ranges only have start/end offsets (no line/column) due to implementation complexity constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant