Added highlight for selected line in checkbox #716
Conversation
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 92.69% 92.69% +<.01%
==========================================
Files 26 26
Lines 1040 1041 +1
Branches 19 19
==========================================
+ Hits 964 965 +1
Misses 76 76
Continue to review full report at Codecov.
|
| var isSelected = i - separatorOffset === pointer; | ||
| output += isSelected ? chalk.cyan(figures.pointer) : ' '; | ||
| output += getCheckbox(choice.checked) + ' ' + choice.name; | ||
| var line = getCheckbox(choice.checked) + choice.name; |
There was a problem hiding this comment.
When rewriting this line, the blank space between the checkbox and the option name has been removed (e.g. []Choice A vs [] Choice A)
There was a problem hiding this comment.
My mistake. Blank space was restored in the latest commit.
|
Thanks! |
|
@SBoudrias is there a chance to publish the changes? |
|
@sergei-startsev I wasn't personally in a hurry, but as you requested it I'll cut a release tonight. |
|
@SBoudrias thanks for the release! |
* Added highlight for selected line in checkbox fixes SBoudrias#479 * Restored space between checkbox and option name
fixes #479
There is inconsistency between list and checkbox selected line. It is highlighted in list and ignored in checkbox module. It is hard to follow what item is currently selected, when there are to many similar items with checkboxes. This fix changes code in order to highlight selected line with cyan color.