Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.37.0 release is too big for Azure Automation #371

Open
FISHMANPET opened this issue Apr 5, 2022 · 0 comments
Open

2.37.0 release is too big for Azure Automation #371

FISHMANPET opened this issue Apr 5, 2022 · 0 comments
Labels
Milestone

Comments

@FISHMANPET
Copy link
Collaborator

The code currently in the release/2.37.0 branch, when built, comes out to around 63,000 lines of code. I've had no issues importing this in a PowerShell session in my local environment (Windows 10, PS5.1, and PS7), and it's imported just fine in the pipelines for testing (PS7 on MacOS, PS7 on Ubuntu, PS7 on Windows, PS5.1 on Windows). But when I try to import it in Azure Automation (specifically in a Hybrid Runbook worker) it fails... somehow, in a way that actually causes the entire Azure Automation job to die and restart rather unceremoniously.

I played around with different library versions, different ways of loading the libraries, etc. Eventually, the way I found that lets it successfully import in that environment is if I remove all the auto-generated code for interacting with Sheets, Docs, and Slides (which amounts to about 32,000 lines of code).

I'm not really sure what to do about this, though I'm not sure it's worth delaying the release or holding back that new functionality.

Long term, it may make sense to split this large monolithic module into multiple smaller modules, the way that modules for Azure, AWS, VMWare, etc are distributed. But that's a pretty large structural change and would generally change how the module is interacted with, and would most likely necessitate a 3.0 release. Though, that's probably what I'll end up doing for myself in my local environment, so that I can use these new auto-generated functions.

Opening this for awareness and discussion.

@FISHMANPET FISHMANPET added this to the v3.0.0 milestone Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant