Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending compatibility of Molecule class instantiation from other file types #11

Open
ianrinehart opened this issue Jul 27, 2021 · 1 comment
Assignees
Labels
ambiguos implementation When there is no obvious unique way of implementing a feature enhancement New feature or request

Comments

@ianrinehart
Copy link
Collaborator

As a normal part of doing any computations, a bunch of structures that I was working with had some errors. I could easily get xyz files, triage the problems, and make the necessary edits so that they will work.

Unfortunately, I have xyz files and there is not a clear way to create molecule class instances. If there were, then I would easily be able to reenter the workflow with these "special" cases.

In other words, can there be a ml.Molecule.from_xyz() and a condition for the .from_file() function to accomodate xyz?

@esalx esalx self-assigned this Jul 27, 2021
@esalx esalx added ambiguos implementation When there is no obvious unique way of implementing a feature enhancement New feature or request labels Jul 27, 2021
@esalx esalx added this to the v0.2.0 milestone Jul 27, 2021
@esalx
Copy link
Contributor

esalx commented Jul 27, 2021

This can be handled already using OpenBabelDriver, but I was definitely hoping to get a from_file() function going that would just use the openbabel backend.

The problem with .xyz files is that the connectivity table has to be guessed, which openbabel can do. But so far I have been trying to avoid it.

@esalx esalx removed this from the v0.2.0 milestone Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ambiguos implementation When there is no obvious unique way of implementing a feature enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants