Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminUnit1 and AdminUnit2 #10

Closed
giorgialodi opened this issue Apr 20, 2021 · 5 comments
Closed

AdminUnit1 and AdminUnit2 #10

giorgialodi opened this issue Apr 20, 2021 · 5 comments

Comments

@giorgialodi
Copy link

In the definition you say that AdminUnit1 is country/region/state. I am not sure if AdminUnit2 is a country again. Isn't it modelled with the AdminUnit1?

Why AdminUnit1 has a Code as type while AdminUnit2 has text? If it is recommended to use NUTS for AdminUnit2 its type should be a Code, right?

In the table of the definitions for AdminUnit1 the type is missing.

@SebastianSK
Copy link

+1

@dimi-schepers
Copy link
Contributor

dimi-schepers commented May 19, 2021

There was a typo in the label of AdminUnitL2. It should be "county/region/state", and not "country". This was fixed accordingly in the spec, see here.

@dimi-schepers
Copy link
Contributor

dimi-schepers commented May 19, 2021

The data type for AdminUnitL1 (i.e. Code) was added to the specification, see here.

@giorgialodi
Copy link
Author

There was a typo in the label of AdminUnitL2. It should be "county/region/state", and not "country". This was fixed accordingly in the spec, see here.

I think that AdminLevel2 cannot be a text but rather a skos:Concept pointing to a controlled vocabulary (recommended NUTS). See also #12

@dimi-schepers
Copy link
Contributor

During the Core Vocs webinar dd. 2021-05-20, an agreement was reached to use Code as datatype for all the AdminUnitLevels. We propose to continue the discussion on the various levels and which codelist to use per level in issue #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants