Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid configurations should throw a proper exception #190

Open
mauricioaniche opened this issue Jun 1, 2023 · 3 comments
Open

Invalid configurations should throw a proper exception #190

mauricioaniche opened this issue Jun 1, 2023 · 3 comments

Comments

@mauricioaniche
Copy link
Contributor

If the configuration is invalid, we should throw a valid exception. Right now, the exception was just a runtime exception being caught the outer most try-catch. We should also re-do the InvalidConfigurationTest so that it ensures the correct exception is being thrown, and not that the writer is called.

@Zakrok09
Copy link
Contributor

Hello 👋

Me and @sandemiroren1 would like to also try this one.

@sandemiroren1
Copy link
Contributor

Hello, we tried tackling this issue this morning but we couldn't find where "the outer most try-catch" was. Could you help us with that?

@mauricioaniche
Copy link
Contributor Author

There was this PR that was never finished and we closed, might give you some insights: #212

That's how I'd implement it too. Add an extra step in the pipeline that'd check that the configuration makes sense. If not, stop the pipeline, mark it as a failure, with a message for the student to know it's not their fault!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants