You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the configuration is invalid, we should throw a valid exception. Right now, the exception was just a runtime exception being caught the outer most try-catch. We should also re-do the InvalidConfigurationTest so that it ensures the correct exception is being thrown, and not that the writer is called.
The text was updated successfully, but these errors were encountered:
There was this PR that was never finished and we closed, might give you some insights: #212
That's how I'd implement it too. Add an extra step in the pipeline that'd check that the configuration makes sense. If not, stop the pipeline, mark it as a failure, with a message for the student to know it's not their fault!
If the configuration is invalid, we should throw a valid exception. Right now, the exception was just a runtime exception being caught the outer most try-catch. We should also re-do the
InvalidConfigurationTest
so that it ensures the correct exception is being thrown, and not that the writer is called.The text was updated successfully, but these errors were encountered: