exception handling Meta Tests #260
Conversation
|
Hi, @AtillaColak, this is a hard MR to review, as I can't compare the previous code with the new one. I think it's easier if you don't have all the comments there, so that git diff can do its job. What exactly are you trying to achieve? Which issue is this about? |
This is an MR for the issue number #227. I've removed the unnecessary comments so it should be easier to review now. |
There was a problem hiding this comment.
System.out and System.err are not reported by Andy; a good way to inform the teacher would be to use GenericFailures with an appropriate exception message (result.genericFailure(this, ...)).
Could you also write a test to verify that your changes work as expected?
|
sure I'll get to it tonight |
|
@martinmladenov Hey Martin could you take a look at this? For some reason, the test I wrote for the exam scenario fails and returns false for the "there is genericfailure" check. I would not want to disturb you if I could have solved it myself but I tried for some hours and was still at a dead end. Maybe you have an idea of what I could be obviously missing, so that I can fix it. |
|
@AtillaColak |
I initially tried to work with compilation exceptions in the
LibraryMetaTestbut as there was already exception handling inRunMetaTestsStepI made the changes there. I was not sure about how to alert the teacher if there was a compilation exception so I worked with console logging. Please Let me know if something else was intended with "alerting the teacher".Another thing to note is that when I made the changes in
LibraryMetaTestas errors would already be handled here, in theRunMetaTestsStepwe would get failing tests that were initially meant to be there for error handling. So this was another reason for why I worked withRunMetaTestsStepfolder instead.I did not delete the other changes, just in case, only commented them out. So when we reach a final decision on where to handle errors, I will delete those commented lines.
Closes #227