Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.2] Breaks with Fabric API #7

Closed
tesseract-two opened this issue Nov 29, 2023 · 2 comments
Closed

[1.20.2] Breaks with Fabric API #7

tesseract-two opened this issue Nov 29, 2023 · 2 comments

Comments

@tesseract-two
Copy link

When Fabric API and OCAIP are on the server, an OCAIP-enabled client fails to connect with the error message Unexpected custom data from client.

Server:
Minecraft 1.20.2
Fabric Loader 0.14.25
OCAIP 1.3.3
Fabric API 0.91.1, 0.90.7, and 0.89.0

Client: 
Minecraft 1.20.2
Fabric Loader 0.14.25
OCAIP 1.3.3

It also breaks when Fabric API is on only the client with this error:
Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: readerIndex(6) + length(1) exceeds writerIndex(6): PooledUnsafeDirectByteBuf(ridx: 6, widx: 6, cap: 6)

Client: 
Minecraft 1.20.2
Fabric Loader 0.14.25
OCAIP 1.3.3
Fabric API 0.91.1

Server:
Minecraft 1.20.2
Fabric Loader 0.14.25
OCAIP 1.3.3

When Fabric API is on both the client and the server, it fails with: Unexpected custom data from client.

Client: 
Minecraft 1.20.2
Fabric Loader 0.14.25
OCAIP 1.3.3
Fabric API 0.91.1

Server:
Minecraft 1.20.2
Fabric Loader 0.14.25
OCAIP 1.3.3
Fabric API 0.91.1

When neither side has Fabric API, everything works perfectly.

OCAIP configuration used throughout:

; Registration password
password=two
; Require OCAIP login
requireOCAIP=false
; Registration sha1pow zero count (complexity, higher value is more time)
sha1pow.zero=
; Registration sha1pow count
sha1pow.count=
@SFort
Copy link
Owner

SFort commented Nov 29, 2023

having an official big API seams to reliably degrade into forge and seamingly no care is put into injections.

anyhow salt aside, probably fixed i'm outa time to test thoroughly, thanks for the report.

@SFort SFort closed this as completed in e2f6c96 Nov 29, 2023
@tesseract-two
Copy link
Author

Works in my testing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants