Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FVCore flop counter ignores additional KV #95

Open
alihassanijr opened this issue Jan 29, 2024 · 2 comments
Open

FVCore flop counter ignores additional KV #95

alihassanijr opened this issue Jan 29, 2024 · 2 comments
Labels
bug Something isn't working front-end Front end related issues

Comments

@alihassanijr
Copy link
Member

No description provided.

@alihassanijr alihassanijr added bug Something isn't working front-end Front end related issues labels Feb 1, 2024
@alihassanijr
Copy link
Member Author

Note: I think I was wrong about this. NATTEN shouldn't have to count flops from additional KV, because NATTEN doesn't perform the cross attn, torch/xformers do that.

@AdityaKane2001
Copy link

I believe using fvcore to measure model FLOPs will need for the registered operator to account for that though..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working front-end Front end related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdityaKane2001 @alihassanijr